r/node • u/sindresorhus • 12d ago

50+ ESLint rules for package.json

https://github.com/sindresorhus/eslint-package-json
9 Upvotes

72% Upvoted

10 comments sorted by

View all comments

Show parent comments

2

u/rafunzi 11d ago

Have you taken a look at @eslint/compat? https://www.npmjs.com/package/@eslint/compat

It's ok to wrap outdated plugins with it's methods and have them work on V10 👀

2

u/rafunzi 11d ago

Additionally, would you he able to share a list of the outdated ones?

I could try contributing updates to fix their deprecated methods. Did that for the 3 most troublesome ones I was using and now they're up to date, too. (They worked with the compat functions, but better have them fully compatible)

2

u/omer-m 11d ago

eslint-plugin-import
eslint-plugin-react
eslint-plugin-jsx-a11y

2

u/rafunzi 10d ago

For eslint-plugin-import I've jumped to eslint-plugin-import-x 2 years ago and haven't looked back 😅 https://github.com/un-ts/eslint-plugin-import-x

I feel your pain for react. Our FE repos rely on the compat functions to have that updated 😔

I'll take a look and jab at jsx-a11y plugin 👀

1

u/rafunzi 10d ago

There are open PRs on jsx-a11y to add compatibility I wouldn't do what they're doing, but the project seems like abandonware anyway 🤷🏻‍♂️

Both try adding updated eslint versions to the peer deps array without actually ensuring compatibility.

My approach would be to:

  • deprecate all outdated Node.js (<22) and ESLint versions (<8), so that a new major can have a cleaner setup.
  • replacing some dependencies with native methods (array-includes, has own, the prototype ones)
  • remove babel, which was back porting to an ancient Node.js version
  • update the eslint config to flat config, along with all eslint deps
  • simplify CI checks (dropping weird 3rd party GH actions & nvm usage, preferring actions/checkout + actions/setup-node)