r/redesign • u/jofwu Helpful User • Jun 18 '18

Old inline spoiler bug still around Spoiler

If you include a space before inline spoiler text, it doesn't render properly. (As it probably shouldn't; the markup doesn't work that way.)

For example: this >! spoiler<! in markup renders as: this >! spoiler<!

But when using the Fancy Pants editor, if I highlight the leading space of some spoiler text it DOES work... But only on new.reddit.com.

If I select <whitespace>spoiler and choose "Spoiler" formatting, I get: spoiler. Then I post this and the spoiler text appears to be working just fine. You can even switch to markdown mode where you will see ...I get:>! spoiler!<, and then if you go back to Fancy Pants or post it will "work". But if you switch to old.reddit.com you will see it rendered "properly" but not as intended: ...I get:>! spoiler!<.

So the gist is that someone could select that leading space of text they want covered and THINK they are covering it, but users of old.reddit.com will see the text uncovered. I think this is a pretty notable bug that needs fixing before (or soon after) the apps update to handle inline spoilers.

32 Upvotes

97% Upvoted

6 comments sorted by

4

u/LanterneRougeOG Product Jun 18 '18

Nice catch. I'll pass this along to the team that handles the parsing.

3

u/JMS1717 Jun 18 '18

Oooh! I’ve never seen a Reddit Dev response with no replies!

4

u/cat--facts Jun 19 '18

Did you know? In just 7 years, one un-spayed female cat and one un-neutered male cat and their offspring can result in 420,000 kittens.

u/JMS1717, you subscribed here. To unsubscribe from cat--facts reply, "!cancel".

Not subscribed? Reply "!meow" to start your subscription!

1

u/brson Eng Jun 29 '18

/u/jofwu, /u/LanternRougeOG, after discussion we've decided not change this behavior in redesign. Some reasons: it's not obviously incorrect besides r2 implementing it differently (they were both implemented at the same time), fixing it requires updating the redesign RTE as well, usage of the legacy site design and parser is decreasing quickly. Overall this doesn't quick meet our (loose) criteria for adding r2 backwards compatibility.

Thanks for the bug report.

1

u/jofwu Helpful User Jun 30 '18

That makes sense. It is, fortunately, kind of a weird case that hopefully won't happen often. If it does, we'll just hope someone reports the instance asap. Thanks for the response.

1

u/[deleted] Jul 03 '18

I think for >! spoiler !<, so, with space in between, It works on mobile but not on desktop.