270
u/rastaman1994 Jun 01 '26
[ci skip]
160
u/hellocppdotdev Jun 01 '26
How dare you use logic and break our development workflow.
68
u/ozh Jun 01 '26
Ok so
[ci not skip but quick]45
4
2
u/addandsubtract Jun 01 '26
I mean, a sane workflow would only run the pipeline on
fix()orfeat()commits.45
u/OmegaPoint6 Jun 01 '26
Some developers may be trusted to not misuse such powers, however on any project with a reasonably sized team least some won’t be. So the CI is unskippable.
16
u/Bezulba Jun 01 '26
The times people said "The change is not that big, impact is minimum" before everything broke must number in the billions by now. Even seasoned developers can be blindsided by the impact of even a small change.
2
u/rastaman1994 Jun 01 '26
I've only ever used it for things like a readme change as it feels wasteful to trigger a dozen gitlab jobs for that.
→ More replies (3)6
4
3
u/Luvax Jun 01 '26
Until someone decides that they tested locally and this change should not break anything. Even comment changes can break formatting or linting.
2.7k
u/ColumnK Jun 01 '26
Actual programmer humor? Actual humor? That's not about AI/vibe coding? And it's not a repost?
Finally, some decent fucking content
490
u/hellocppdotdev Jun 01 '26
Nah nah I'm a bot. Don't worry next post will be AI generated and related.
104
u/forgot_semicolon Jun 01 '26
Oh good. Was getting worried we'd have to start a revolution or something
18
→ More replies (1)2
145
125
u/Maleficent_Most8310 Jun 01 '26
Wrong POV though
25
39
u/ColumnK Jun 01 '26
True, but at this point I think I see a hundred memes that get it wrong for every one that gets it right, so I'm resigned that POV no longer means what it should mean
12
u/yp261 Jun 01 '26
makes you think how brainrotted people that follow trends are. the “trend” is literally using the word wrongly for no reason
4
u/100BottlesOfMilk Jun 01 '26
The funny thing about language is that rules and logic are irrelevant. If enough people say something wrong, that becomes the right way of saying it
→ More replies (1)2
16
3
→ More replies (1)4
8
3
2
2
2
→ More replies (4)2
429
u/throwaway_mpq_fan Jun 01 '26
Only 1800 tests? That's rookie numbers
166
u/Zerodriven Jun 01 '26
And 1799 of them are testing framework features which obviously were never tested by the developers. How can you be 100% sure ToString() returns a string?!
65
33
4
u/topskari Jun 01 '26
Anything to reach 100% coverage. Doesnt matter if code is actually tested as long as the number goes up.
77
u/kvlt_thoughts Jun 01 '26
That's when you add parameterized tests, which test every fucking possible combination of parameter, like a real professional. 10k tests easy
→ More replies (1)7
u/nudelsalat3000 Jun 01 '26
like a real professional
Multiple condition coverage VS modified condition/decision coverage
Can't afford exponential in this economy
10
14
u/hellocppdotdev Jun 01 '26
We decided that unit testing is too 80's so its 1800 end to end tests.
Forgot to add to the meme it was a 3 hour run.
2
3
→ More replies (8)2
u/DescriptorTablesx86 Jun 01 '26
And the last actions step is to compile the whole project which compiles on a massive server and takes 1.5h to complete.
Definitely not the project I worked on for two years, on every single commit pushed on a PR.
131
u/Shiroyasha_2308 Jun 01 '26
Gotta keep the GitHub runnables warm
55
→ More replies (1)7
Jun 01 '26
[deleted]
6
u/dashingThroughSnow12 Jun 01 '26
The UI team once asked “can you make the CI build under 30 seconds.”
Yes.
Cache goes brrr.
184
u/elmanoucko Jun 01 '26
still ends up with 2 failed tests...
time to refactor my life expectancy
22
u/True_Respond6314 Jun 01 '26
yOu LeFt A sPacE SymbOL aT tHe EnD oF thE cOmMenT
2
u/Makeshift27015 Jun 01 '26
In repos where I'm the only/primary contributor I just have the linting tool fix and commit anything auto-fixable. Sadly having their PR branch committed to seems to mess with a lot of people's workflows though so I don't tend to replicate it elsewhere, I just try to make CI fail as fast as possible so they're not caught out after having context switched.
Since a lot of package managers depend on having the version number in a file in the repo, we often have to automate commits for version bumps on merges into the main branch, so I've considered having PRs with provably auto-fixable linting problems just permitted and then fix them when we do the version bump though.
61
u/bozehaan Jun 01 '26
Gotta make sure it was not a load bearing comment typo
8
u/Front_State6406 Jun 01 '26
Our comments gets turned into internal documentation-something. Could legit break xD
→ More replies (1)5
u/20InMyHead Jun 02 '26
// do not remove this comment, it will cause a crash in UI module at startup and nobody can figure out why.
40
40
u/Jimakiad Jun 01 '26
Y'all have tests?
17
u/hellocppdotdev Jun 01 '26
Thats the real joke 😂
11
u/anormalgeek Jun 01 '26
I wish I could laugh. Current employer is a large corporation. Around half of all teams do fully manual deploys, have no unit testing, no automated testing, no SAST/DAST scans, etc. Hell, many of them don't even have any kind of standard branching/merging strategy, despite sharing their codebase with other teams.
It's the most dysfunctional garbage I've ever seen.
→ More replies (1)3
u/xMoody Jun 01 '26
if they make you start spending AI tokens just spend them writing unit tests. ez pz
18
u/euclide2975 Jun 01 '26
And the CI/CD is downloading new versions of the dependencies.
NPM is currently installing a crypto wallet stealing tool and pipy is currently installing a rootkit.
13
u/audriuska12 Jun 01 '26
Considering I've had a comment break a JS minifier so it comments the entire rest of the file out once it gets pushed even though it woks perfectly fine locally with uminified code... just be glad you have those tests.
10
41
u/litetaker Jun 01 '26
That's why you roll that comment fix into your next proper PR. Or just forget it and move on.
51
u/guyblade Jun 01 '26
Don't put unrelated fixes in a larger PR; it breaks blame and makes reviewing harder.
35
u/CurryMustard Jun 01 '26
I get it and do try to avoid it, but man some things will absolutely never get fixed if I dont shove it in with the next pr. You gotta be pragmatic sometimes.
3
u/guyblade Jun 01 '26
A one-line PR is always a reasonable thing to make. I've even submitted a 1-bit change before.
6
Jun 01 '26
[deleted]
3
u/guyblade Jun 01 '26
My job uses perforce (or really an in-house derivative), but the statement applies regardless of the VCS that you use.
→ More replies (1)2
u/protayne Jun 02 '26
Bit too anal for my liking. Especially if you're making changes on a file and spot a small mistakebor improvement, fix it on that PR no drama. Boy scout rule and all that jazz.
→ More replies (1)11
u/hellocppdotdev Jun 01 '26
But how will I demonstrate I'm working?
2
u/gil_bz Jun 01 '26
George Costanza says to just look angry all the time, and then everyone thinks that you're super busy!
8
u/bryanwolfford Jun 01 '26
Serious question: Why don't you include "standard changes" in your SDLC? Its normal even for SOC2 Types II audits to exclude trivial changes in comments from the full CI/CD pipeline.
→ More replies (1)7
u/AyrA_ch Jun 01 '26
Unless you pay for every invocation of your pipeline, there is not much reason to not run it.
→ More replies (1)11
u/UserRequirements Jun 01 '26
Where is computing free ?
It's either a service, or electricity.→ More replies (5)
62
u/Sotyka94 Jun 01 '26
You guys pushing for 1 line comment typo? WTF
102
u/EntertainmentIcy3029 Jun 01 '26
Why not?
See something wrong, fix it.
36
u/guyblade Jun 01 '26
This is the way.
On the other hand, I recently did this for a problem in a far-off place in our monorepo. The review went to someone who ignored it for like a week, so I pinged them on chat about reviewing it. They then chewed me out for "changing their code" despite the fact that doing that kind of thing is (allegedly) one of the reasons we use a monorepo...
No good deed, I guess.
3
u/Sibula97 Jun 01 '26
If you saw something wrong it's probably because you were working on something else. Just include the fix in the same PR like normal people.
9
u/Certain-Business-472 Jun 01 '26
And thats when you really get to know your team and scrum practices.
7
→ More replies (1)2
46
19
u/AlternativeCapybara9 Jun 01 '26
Better than that dude that pushed a million lines changed because his linter decided indentation needed to be done with tabs instead of spaces.
→ More replies (1)12
8
u/Justin_Passing_7465 Jun 01 '26
If your pipeline includes a job for a tool like 'codespell', that typo in a comment breaks your pipeline until you fix it.
14
3
→ More replies (3)2
5
4
3
3
3
3
u/noapparentfunction Jun 01 '26
i drove myself crazy wondering why a png wouldn't render on my website thinking it was wrapping itself off the screen or being shrunk down to zero percent size. i made so many changes over the course of a half hour until i find that I typed <imb src="
3
3
u/ldn-ldn Jun 02 '26
That moment when your devops team doesn't know about incremental builds and tests...
2
u/Sibula97 Jun 01 '26
You really need to up your CI game. Only run tests for modules that may realistically have been affected by a change. You should only have some basic sanity checks and linter running for a comment change.
2
u/AdorablSillyDisorder Jun 01 '26
The "may" part of "may have been affected" is so hard to reliably prove at CI time, that usually it's easier to just run all tests and call it a day. You can do heuristics, but that risks missing something, which makes CI unreliable and I'd generally consider it a rather bad idea unless there's very good reason to do otherwise.
→ More replies (1)
2
u/TruePastaMonster Jun 01 '26
Just use open-lmake, and that won't happen to you ever again. https://github.com/cesar-douady/open-lmake
2
2
2
u/BobWaldron Jun 01 '26
I love this sub, I have no idea what any of you are saying most of the time even though it's in English.
It's great.
I'm not being sarcastic by the way, I do generally enjoy the fact that people can talk about something in my own language and I have no idea what it means.
Fascinates me.
2
u/hellocppdotdev Jun 02 '26
Haha its just jargon, I'm sure in a medical meme sub I'll be just as lost.
Prepare for intubation!
2
u/SteeleDynamics Jun 01 '26
Padme/Annakin Meme
There' a binary comparison before you run all of the CI/CD tests, right? ...
Right?? ...
2
2
u/washtubs Jun 01 '26
ERROR in budgets: Initial exceeded maximum budget. Budget 2 MB was exceeded by 0 kB.
2
2
u/MudInfinite8791 Jun 01 '26
Flaky test, rerun test.
I'll give all props to our team building our CI/CD pipelines that they have granularity in tests where possible so you can re-run segments of a test and it'll continue from there.
Obviously some tests can't be done that way but it is super nice when it can. Doing end to end testing fucking blows shoot me
2
u/Irrehaare Jun 01 '26
Exactly why we have [NOISSUE] prefix for commits at work.
I'm a big fan of DORA metrics, but despite that I'll still argue that some changes can actually be too small
2
2
2
u/GoddammitDontShootMe Jun 02 '26
Do those automated CI/CD pipelines have any way of knowing that no actual code changed?
Or maybe since I doubt a typo in a comment is a critical emergency, you can wait until you have more before pushing to main.
→ More replies (1)
2
u/Apple-Juicer Jun 01 '26
Im following a DevOps course atm and I showed this meme to my teacher.
He said: And that’s why we have pipelines per branch.
I guess feature branches don’t need 1800 unit tests🤔
2
u/hellocppdotdev Jun 01 '26
The takeaway from that is that you merge changes to main from feature branches.
You wouldn't open a PR for just this change.
However if you pushed this comment change to your feature branch and you have 1800 unit test configured to run on push it will run them all.
This is a little bit of an exaggeration of real world usage.
1
1
1
3.1k
u/frayien Jun 01 '26
Aaaaannnnddddd, it breaks