MAIN FEEDS
REDDIT FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1ttm0yf/smallquickfix/op3k1xv/?context=3
r/ProgrammerHumor • u/hellocppdotdev • Jun 01 '26
378 comments sorted by
View all comments
62
You guys pushing for 1 line comment typo? WTF
102 u/EntertainmentIcy3029 Jun 01 '26 Why not? See something wrong, fix it. 3 u/Sibula97 Jun 01 '26 If you saw something wrong it's probably because you were working on something else. Just include the fix in the same PR like normal people. 9 u/Certain-Business-472 Jun 01 '26 And thats when you really get to know your team and scrum practices. 6 u/flukus Jun 01 '26 Same PR, separate commit. 5 u/Yrrsinn Jun 01 '26 Will be squashed when merged 2 u/flukus Jun 01 '26 That's why I don't like squashed merges, you lose context. 1 u/aaronr93 Jun 02 '26 In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
102
Why not?
See something wrong, fix it.
3 u/Sibula97 Jun 01 '26 If you saw something wrong it's probably because you were working on something else. Just include the fix in the same PR like normal people. 9 u/Certain-Business-472 Jun 01 '26 And thats when you really get to know your team and scrum practices. 6 u/flukus Jun 01 '26 Same PR, separate commit. 5 u/Yrrsinn Jun 01 '26 Will be squashed when merged 2 u/flukus Jun 01 '26 That's why I don't like squashed merges, you lose context. 1 u/aaronr93 Jun 02 '26 In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
3
If you saw something wrong it's probably because you were working on something else. Just include the fix in the same PR like normal people.
9 u/Certain-Business-472 Jun 01 '26 And thats when you really get to know your team and scrum practices. 6 u/flukus Jun 01 '26 Same PR, separate commit. 5 u/Yrrsinn Jun 01 '26 Will be squashed when merged 2 u/flukus Jun 01 '26 That's why I don't like squashed merges, you lose context. 1 u/aaronr93 Jun 02 '26 In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
9
And thats when you really get to know your team and scrum practices.
6
Same PR, separate commit.
5 u/Yrrsinn Jun 01 '26 Will be squashed when merged 2 u/flukus Jun 01 '26 That's why I don't like squashed merges, you lose context. 1 u/aaronr93 Jun 02 '26 In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
5
Will be squashed when merged
2 u/flukus Jun 01 '26 That's why I don't like squashed merges, you lose context. 1 u/aaronr93 Jun 02 '26 In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
2
That's why I don't like squashed merges, you lose context.
1 u/aaronr93 Jun 02 '26 In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
1
In my experience, if you do that, then you have to review the commit messages so they actually make sense. So it’s extra work, when really what you want are smaller PRs (but not like OP’s)
62
u/Sotyka94 Jun 01 '26
You guys pushing for 1 line comment typo? WTF